lkml.org 
[lkml]   [2011]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cciss: Add missing allocation in scsi_cmd_stack_setup and corresponding deallocation
On Fri, Mar 11, 2011 at 08:09:39PM +0100, Jens Axboe wrote:
> On 2011-03-10 21:22, Stephen M. Cameron wrote:
> > From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> >
> > This bit got lost somewhere along the way. Without this, panic.
>
> This doesn't apply cleanly, neither hunk. I hand applied it. Please let
> me know what a patch is against in the future, if it doesn't apply
> "anywhere".

Oh... I see what happened.

That patch was fixing something which was accidentally
left out of this patch:

http://marc.info/?l=linux-kernel&m=129840572232151&w=2

which I mistakenly thought was present in 2.6.38-rc7,
but it's not present (quite likely because without the
missing bit, it causes a panic), It's sitting in my stack of
patches still.

[scameron@localhost linux-2.6.38-rc7]$ stg series | grep cciss
+ cciss-hoist-tag-masking-out-of-loop
+ cciss-inform-controller-we-are-using-32-bit-tags
+ cciss-mask-off-error-bits-before-calling-pci-free-consistent
+ cciss-remove-unnecessary-casts
+ cciss-fix-missed-command-status-value-CMD_UNABORTABLE
+ cciss-add-cciss_tape_cmds-module-parameter
+ cciss-fix-missing-initialization-in-scsi-cmd-stack-setup
+ cciss-export-resettable-host-attribute
+ cciss-fix-sense-data-copying-code

What needs to happen is I combine cciss-add-cciss_tape_cmds-module-parameter
and cciss-fix-missing-initialization-in-scsi-cmd-stack-setup into one
working patch.

Sorry about that. I need to slow down. I'm making too many mistakes.

-- steve



>
> I marked this one as stable backport, too.
>
> --
> Jens Axboe


\
 
 \ /
  Last update: 2011-03-11 20:49    [W:2.021 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site