Messages in this thread | | | Date | Fri, 11 Mar 2011 09:35:57 -0500 | From | Andy Gospodarek <> | Subject | Re: [Patch V2] bonding: fix netpoll in active-backup mode |
| |
On Wed, Mar 09, 2011 at 08:34:43PM +0800, Cong Wang wrote: > 于 2011年03月09日 05:24, Andy Gospodarek 写道: >> On Tue, Mar 08, 2011 at 05:58:56PM +0800, Amerigo Wang wrote: >>> V2: avoid calling slave_diable_netpoll() with write_lock_bh() held. >>> >>> netconsole doesn't work in active-backup mode, because we don't do anything >>> for nic failover in active-backup mode. We should disable netpoll on the >>> failing slave when it is detected down and enable netpoll when it becomes >>> the active slave. >>> >>> Tested by ifdown the current active slave and ifup it again for several times, >>> netconsole works well. >>> >>> Signed-off-by: WANG Cong<amwang@redhat.com> >>> Cc: Neil Horman<nhorman@tuxdriver.com> >>> >> >> It seems like you are going to a lot of trouble to fix a bug where >> netpoll will not be setup on any interface that is down when enslaved. >> That seems to be the only path that would not have slave->np setup >> properly at enslavement. >> >> Did you ever try just this? > > That was my first thought, but I was over-worried about the failing slave. > This way should work too. Mind to send it as a normal patch? :) >
I'm happy to submit the patch if it works in your environment.
I do not think anyone likes un-tested patches.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |