[lkml]   [2011]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/3] tty: serial: Use hub6_serial_X when CONFIG_SERIAL_8250_HUB6 is defined
On Friday 11 March 2011, Alan Cox wrote:
> Most of these are not needed
> It is also such a miniscule amount of code it seems like it does not
> justify the complexity of being configurable this way.

The point is that the 8250 driver stands in the way of allowing
to build the kernel on architectures that do not support ISA or PCI
I/O spaces. Right now, the common solution is to do

#define inb(x) readb(void __iomem *)(x))

or some variation of this. It's fine as long as this code never gets
called, but incorrect nonetheless.

I think it would be much cleaner if architectures that cannot do this
would not have to define those functions and we could make sure that
all drivers that do inb() have correct Kconfig dependencies.


 \ /
  Last update: 2011-03-11 14:59    [W:0.066 / U:4.952 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site