lkml.org 
[lkml]   [2011]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] tty: serial: Fix build on architecture that does not have ioport
    On Fri, 11 Mar 2011 21:58:11 +0900
    Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> wrote:

    > Some CPU's do not have ioport. Therefore, these do not have inX/outX.

    The results of doing that are usually horrible and add a lot of
    configuration and ifdefs.

    > This adds CONFIG_SERIAL_8250_IOPORT. When this is enable, 8250 driver
    > provides ioports access. And this is not enable with the CPU without
    > ioports.

    NAK this - all the ifdefs make it hard to maintain. If your platform does
    not support inb or outb then it is easier and needs no device
    modifications if you just have an architecture file which is something
    like

    u8 inb(....)
    {
    WARN_ON(1);
    return 0xFF;
    }

    etc

    You will then get a backtrace if the methods are called rather than
    having to hack all the drivers. In addition if your platform ever has a
    PCI bridge attached to it you will now be able to replace those methods
    and provide PCI I/O space access, as you will need for many PCI devices.


    \
     
     \ /
      Last update: 2011-03-11 14:57    [W:0.021 / U:32.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site