lkml.org 
[lkml]   [2011]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH 14/14] xen: events: propagate irq allocation failure instead of panicking
From
Date
On Thu, 2011-03-10 at 05:38 +0000, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 09, 2011 at 05:41:26PM +0000, Ian Campbell wrote:
> > Running out of IRQs need not be fatal to the machine as a whole.
>
> Do the backends/frontends deal with this appropiately?
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Cc: Jeremy Fitzhardinge <jeremy@goop.org>
> > ---
> > drivers/xen/events.c | 22 ++++++++++++++--------
> > 1 files changed, 14 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> > index 51c6a5b..c6f2a2e 100644
> > --- a/drivers/xen/events.c
> > +++ b/drivers/xen/events.c
> > @@ -406,7 +406,7 @@ static void xen_irq_init(unsigned irq)
> > list_add_tail(&info->list, &xen_irq_list_head);
> > }
> >
> > -static int xen_allocate_irq_dynamic(void)
> > +static int __must_check xen_allocate_irq_dynamic(void)
>
> What is the '__must_check' for?

It makes gcc warn if callers don't check the return code. Perhaps
overkill for so few callers but it made it easy to be sure I'd
propagated the error code.

Ian.




\
 
 \ /
  Last update: 2011-03-10 10:01    [W:0.033 / U:10.592 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site