Messages in this thread Patch in this message | | | Subject | Re: [Xen-devel] [PATCH 06/14] xen: events: refactor GSI pirq bindings functions | From | Ian Campbell <> | Date | Thu, 10 Mar 2011 08:37:18 +0000 |
| |
On Thu, 2011-03-10 at 04:00 +0000, Konrad Rzeszutek Wilk wrote: > if (0 == nr_ioapics) { > > - for (irq = 0; irq < NR_IRQS_LEGACY; irq++) > > - xen_allocate_pirq(irq, 0, "xt-pic"); > > + for (irq = 0; irq < NR_IRQS_LEGACY; irq++) { > > + pirq = xen_allocate_pirq_gsi(irq); > > + if (pirq < 0) > > + break; > > Would it make sense to print a warning here?
I was almost tempted by a BUG_ON but:
8<-------------------------------------------------
From b5f92c9d914988cd29c45a84cde462a8588467b6 Mon Sep 17 00:00:00 2001 From: Ian Campbell <ian.campbell@citrix.com> Date: Thu, 10 Mar 2011 08:36:55 +0000 Subject: [PATCH] xen: irq: warn if we cannot allocate a PIRQ for the legacy IRQs in dom0
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- arch/x86/pci/xen.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index 3ee5f4a..ca58a73 100644 --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c @@ -452,7 +452,8 @@ void __init xen_setup_pirqs(void) if (0 == nr_ioapics) { for (irq = 0; irq < NR_IRQS_LEGACY; irq++) { pirq = xen_allocate_pirq_gsi(irq); - if (pirq < 0) + if (WARN(pirq < 0, + "Could not allocate PIRQ for legacy interrupt\n")) break; irq = xen_bind_pirq_gsi_to_irq(irq, pirq, 0, "xt-pic"); } -- 1.5.6.5
| |