Messages in this thread | | | Date | Thu, 10 Mar 2011 21:39:08 -0500 | From | Mathieu Desnoyers <> | Subject | Re: [PATCH 0/2] jump label: update for .39 |
| |
* Ralf Baechle (ralf@linux-mips.org) wrote: > On Thu, Mar 10, 2011 at 04:22:14PM -0500, Mathieu Desnoyers wrote: > > > You seem to be contradicting yourself here. I'm concerned about having > > "structures" of a size not power of two. Can we simply either > > > > - Add a padding element at the end > > or > > - use .align 4*sizeof(long) at the beginning > > > > to make sure the linker won't put any holes when it puts objects > > together ? > > It may only be a technicality but but careful with .align. On some > architectures .align x will align to a multiple of x; on other > architectures to 2^x. Another reason to stick to C wherever possible.
Thanks for the reminder! Not sure if using C is practical in the case of jump labels though. As Michael pointed out, using .balign might be better here.
Mathieu
> > Ralf
-- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com
| |