Messages in this thread | | | Subject | Re: [PATCH 0/2] jump label: update for .39 | From | Steven Rostedt <> | Date | Thu, 10 Mar 2011 13:53:56 -0500 |
| |
On Thu, 2011-03-10 at 10:47 -0800, David Daney wrote:
> The alignment requested by the assembler will have to satisfy *all* the > requested alignments, so manually forcing everything to .align 8 (or > .align 4 for 32-bit) should ensure that the linker doesn't put in any holes.
I would agree with the assessment although, I don't know that it is documented anywhere that this is what happens. As the previous "bug" with the trace_events was solved by me adding .align(4) everywhere, I would think that .align(sizeof(long)) would work here too.
It may be a good ideal to force this alignment, and not add wasted space. If anything, if this (hypothetical) bug appears, it will most likely show up as a crash on boot up. I'm not too concerned about it.
-- Steve
| |