lkml.org 
[lkml]   [2011]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] trace-cmd: fold option parsing
From
Date
On Thu, 2011-03-10 at 17:58 +0800, Lai Jiangshan wrote:
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>

Thanks!

>
> +#define OPT_debug 255
> +

>
> +#define OPT_cpu 255
> +#define OPT_events 254
> +#define OPT_kallsyms 253
> +

I wonder if it would look cleaner if we converted them all to enums:

enum {
OPT_kallsyms = 253,
OPT_events = 254,
OPT_cpu = 255,
};
As in the kernel, defines look ugly, and can have side-effects.

-- Steve




\
 
 \ /
  Last update: 2011-03-10 14:19    [from the cache]
©2003-2011 Jasper Spaans