Messages in this thread | | | Subject | Re: [PATCH 3/3] trace-cmd: fold option parsing | From | Steven Rostedt <> | Date | Thu, 10 Mar 2011 08:16:07 -0500 |
| |
On Thu, 2011-03-10 at 17:58 +0800, Lai Jiangshan wrote: > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Thanks!
> > +#define OPT_debug 255 > +
> > +#define OPT_cpu 255 > +#define OPT_events 254 > +#define OPT_kallsyms 253 > +
I wonder if it would look cleaner if we converted them all to enums:
enum { OPT_kallsyms = 253, OPT_events = 254, OPT_cpu = 255, };
As in the kernel, defines look ugly, and can have side-effects.
-- Steve
| |