lkml.org 
[lkml]   [2011]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] hid: ntrig NO_INIT_REPORTS
    On Wed, 9 Mar 2011, Rafi Rubin wrote:

    > Probing reports does bad things with some ntrig firmwares, better to
    > just leave them alone.
    >
    > Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
    >
    > ---
    >
    > This resolves an annoying delay on initialization and reduces the
    > chance of the device coming up in an odd state or crashing.

    Applied.

    > ---
    > drivers/hid/hid-ntrig.c | 3 ++-
    > 1 files changed, 2 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
    > index b1e9cca..850ba14 100644
    > --- a/drivers/hid/hid-ntrig.c
    > +++ b/drivers/hid/hid-ntrig.c
    > @@ -837,7 +837,8 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)
    > struct hid_report *report;
    >
    > if (id->driver_data)
    > - hdev->quirks |= HID_QUIRK_MULTI_INPUT;
    > + hdev->quirks |= HID_QUIRK_MULTI_INPUT
    > + | HID_QUIRK_NO_INIT_REPORTS;
    >
    > nd = kmalloc(sizeof(struct ntrig_data), GFP_KERNEL);
    > if (!nd) {
    > --
    > 1.7.4.1
    >

    --
    Jiri Kosina
    SUSE Labs, Novell Inc.


    \
     
     \ /
      Last update: 2011-03-10 11:41    [W:0.047 / U:91.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site