lkml.org 
[lkml]   [2011]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3] i2c-eg20t: support new device OKI SEMICONDUCTOR ML7213 IOH
Date
Hi Ben,

On Wednesday, March 02, 2011 9:39 AM, Ben Dooks wrote:
> Ok, will apply to i2c-next.
Thank you for your applying.

> > +/* Definition for ML7213 by OKI SEMICONDUCTOR */
> > +#define PCI_VENDOR_ID_ROHM 0x10DB
> > +#define PCI_DEVICE_ID_ML7213_I2C 0x802D
>
> we should get this moved to a pci header file at somepoint.
Do you mean include/linux/pci_ids ?


> > + strcpy(pch_adap->name, KBUILD_MODNAME);
>
> really should be strlcpy() and ensure that the string length is used.
OK.
We will update in next update.


> > - pch_i2c_init(&adap_info->pch_data);
> > + pch_i2c_init(&adap_info->pch_data[i]);
> > + }
> > ret = request_irq(pdev->irq, pch_i2c_handler, IRQF_SHARED,
> > - KBUILD_MODNAME,&adap_info->pch_data);
> > + KBUILD_MODNAME, adap_info);
>
> how about using dev_name() of the platform device to register
> these things?
Sorry, I can't understand your saying.
Could you explain in more detail ?

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.



\
 
 \ /
  Last update: 2011-03-02 04:21    [W:0.068 / U:1.772 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site