lkml.org 
[lkml]   [2011]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 1/1] PRUSS UIO driver support
On Tue, Mar 01, 2011 at 10:45:25PM +0100, Thomas Gleixner wrote:
>
> > +
> > + spin_lock_init(&lock);
>
> Sigh. DEFINE_SPINLOCK(lock); already initializes the lock.
>
> It's not the purpose of a review to tell you what you need to change
> mechanically. Reviewers hint to a correct solution and you are
> supposed to lookup what that solution means and act accordingly. If
> you do not understand the hint or its implications please ask _before_
> sending a new patch set.

Correct. But I'm to blame here, too, since I suggested the wrong solution.
Sorry for that, Gangadhar!

Thanks,
Hans



\
 
 \ /
  Last update: 2011-03-01 23:39    [W:0.053 / U:1.668 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site