lkml.org 
[lkml]   [2011]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RFC: [PATCH 0/5] staging: sep: Enable kernel crypto
On Tue, Mar 01, 2011 at 02:10:09PM -0700, Allyn, Mark A wrote:
> Greg writes:
>
> Why? What does this mean to me? To users? You need to sell this new
> feature to me a LOT before I will take it as I really want and need to
> see this driver fixed up first before you can add new features to it.
>
> thanks,
>
> greg k-h
>
>
> =================
>
> Greg:
>
> I agree; I will work on getting the current core driver out of staging prior to making the kernel crypto changes.

First off, please fix your email client to do proper quoting and wrap
lines at 72 columns. Even Outlook can do this so there really is no
excuse anymore...

>
> What are the major issues with the core driver? I know about the current items in the TODO list having to do with the unused ioctl calls and structures.
>
> What other issues are there?

That's a good place to start, fix those up and when you feel you have
addressed everything, ask for a review of the code and we can go from
there.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-03-01 23:17    [W:0.044 / U:9.528 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site