lkml.org 
[lkml]   [2011]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: keucr: Remove all type defines
On Tue, Mar 01, 2011 at 08:29:50PM +0100, Roel Van Nyen wrote:
> Remove all type defines from driver and replace them with kernel built-in types.
>
> Signed-off-by: Roel Van Nyen <roel.vannyen@gmail.com>

Some of your other patches were merged so this doesn't apply to
linux-next any more.

> -typedef u8 BOOLEAN;

It might be better to use bool type or int for boolean variables. But
that can't be done automatically, it has to be audited carefully. I
don't feel strongly about this, I'm just throwing it out there as food
for thought. You are using the remove-typedef program btw?

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-03-01 21:03    [W:0.046 / U:41.988 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site