Messages in this thread | | | Date | Tue, 1 Mar 2011 14:33:07 -0500 (EST) | From | Alan Stern <> | Subject | Re: [linux-pm] [RFC,PATCHv3 0/3] sdhci runtime_pm implementation |
| |
On Tue, 1 Mar 2011, Pierre Tardy wrote:
> Please find sdhci runtime_pm implementation. > > It uses clock gating fw as a tip to know when our chip is idle. > It implements wake up from card insertion/removal. > > This is RFC, please dont merge yet. I really would like to have deep review > from PCI linux-pm guys. > > Opens are: > > 1/ Not sure if the pci configs in the driver in rpm_suspend/resume flow > are not duplicate from what the core is doing.
There may be one or two small errors.
> 2/ Wakeup from D3hot: I cannot find any driver that is implementing it in current upstream,
Other drivers do it, but they use PCI PME# instead of interrupts.
> I'm not sure if I'm doing it the good way. > We have the exact same issue for our not yet upstreamable usb-otg driver. > Not sure if this cannot be implemented generically in core.
Alan Stern
| |