lkml.org 
[lkml]   [2011]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] Staging: hv: Rename driver_context to hyperv_driver
On Fri, Feb 25, 2011 at 06:07:38PM -0800, K. Y. Srinivasan wrote:
> The title says it all.

No it doesn't. You should have done this on the last patch to keep me
from complaining about that name.

Oh, and the extra space, drop it please.

> --- a/drivers/staging/hv/blkvsc_drv.c
> +++ b/drivers/staging/hv/blkvsc_drv.c
> @@ -116,10 +116,10 @@ struct block_device_context {
> };
>
> /* Per driver */
> -struct blkvsc_driver_context {
> +struct blkvsc_hyperv_driver {
> /* !! These must be the first 2 fields !! */
> /* FIXME this is a bug! */
> - struct driver_context drv_ctx;
> + struct hyperv_driver drv_ctx;
> struct storvsc_driver_object drv_obj;
> };
>

Hey look, that Subject: and changelog body actually lied. It didn't say
it all. In fact, it didn't say enough, or you just renamed a different
structure because it felt nice.

{sigh}

One thing per patch, with full description. I'm getting tired of
repeating Documentation/CodingStyle for this subsystem when patches are
submitted.

It's as if no one even listens to me...

{sniff}

greg k-h


\
 
 \ /
  Last update: 2011-03-01 06:49    [W:0.051 / U:8.560 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site