Messages in this thread Patch in this message | | | From | Aaro Koskinen <> | Subject | [PATCH] procfs: fix /proc/<pid>/maps heap check | Date | Tue, 1 Mar 2011 18:26:53 +0200 |
| |
The current check looks wrong and prints "[heap]" only if the mapping matches exactly the heap. However, the heap may be merged with some other mappings, and there may be also be multiple mappings.
Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com> Cc: stable@kernel.org --- fs/proc/task_mmu.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 60b9148..f269ee6 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -249,8 +249,8 @@ static void show_map_vma(struct seq_file *m, struct vm_area_struct *vma) const char *name = arch_vma_name(vma); if (!name) { if (mm) { - if (vma->vm_start <= mm->start_brk && - vma->vm_end >= mm->brk) { + if (vma->vm_start <= mm->brk && + vma->vm_end >= mm->start_brk) { name = "[heap]"; } else if (vma->vm_start <= mm->start_stack && vma->vm_end >= mm->start_stack) { -- 1.5.6.5
| |