[lkml]   [2011]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support
    Hi Pierre,

    On Sun, Feb 06, 2011 at 07:02:49PM +0100, Pierre Tardy wrote:
    > From: Yunpeng Gao <>
    > Follow the kernel runtime PM framework, enable runtime PM support of the
    > sdhci host controller with pci interface.
    > Note that this patch implements runtime_pm but now actually detects
    > activity.
    > It relies on higher level (childrens) to do actual waking up
    > Activity detection is put in following patch

    Testing this patchset in linux-next-20100208 gives:

    [ 10.829223] sdhci: Secure Digital Host Controller Interface driver
    [ 10.829548] sdhci: Copyright(c) Pierre Ossman
    [ 10.883906] sdhci-pci 0000:0d:00.0: SDHCI controller found [1180:e822] (rev 1)
    [ 10.884533] sdhci-pci 0000:0d:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
    [ 10.885189] sdhci-pci 0000:0d:00.0: Will use DMA mode even though HW doesn't fully claim to support it.
    [ 10.886176] sdhci-pci 0000:0d:00.0: setting latency timer to 64
    [ 10.886819] Registered led device: mmc0::
    [ 10.887281] mmc0: SDHCI controller on PCI [0000:0d:00.0] using DMA
    [ 10.887724] sdhci-pci 0000:0d:00.0: Unbalanced pm_runtime_enable!
    [ 10.888498] sdhci-pci 0000:17:00.0: SDHCI controller found [1180:e822] (rev 1)
    [ 10.889179] sdhci-pci 0000:17:00.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19
    [ 10.889876] sdhci-pci 0000:17:00.0: Will use DMA mode even though HW doesn't fully claim to support it.
    [ 10.890924] sdhci-pci 0000:17:00.0: setting latency timer to 64
    [ 10.891387] Registered led device: mmc1::
    [ 10.891900] mmc1: SDHCI controller on PCI [0000:17:00.0] using DMA
    [ 10.892280] sdhci-pci 0000:17:00.0: Unbalanced pm_runtime_enable!

    (Note the last line above.)

    I then removed the card and reinserted it, but there's no dmesg output
    related to the reinsert, only to the card removal:

    [ 65.381047] mmc0: card d555 removed

    So, card insertion is broken. I then did rmmod sdhci-pci && modprobe
    sdhci-pci, and it picked up the card again.

    There was also a weird UI hang for a few hundred msecs around the time
    the second modprobe happened, but I don't expect you to be able to do
    anything about that without a more helpful report; if it happens again
    I'll try to record what's going on using ftrace.

    Full dmesg is at:


    Chris Ball <> <>
    One Laptop Per Child

     \ /
      Last update: 2011-02-10 05:39    [W:0.020 / U:164.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site