lkml.org 
[lkml]   [2011]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Platform: add Samsung Laptop platform driver
    On Wed, Feb 09, 2011 at 02:44:19PM -0800, Randy Dunlap wrote:
    > On Wed, 9 Feb 2011 14:40:06 -0800 Greg KH wrote:
    >
    > > From: Greg Kroah-Hartman <gregkh@suse.de>
    > >
    > > This adds the samsung-laptop driver to the kernel. It now supports
    > > all known Samsung laptops.
    > >
    > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    > > ---
    > > Documentation/ABI/testing/sysfs-driver-samsung-laptop | 19
    > > drivers/platform/x86/Kconfig | 13
    > > drivers/platform/x86/Makefile | 1
    > > drivers/platform/x86/samsung-laptop.c | 768 ++++++++++++++++++
    > > 4 files changed, 801 insertions(+)
    > >
    > > Matthew, this is a copy of the latest version in the linux-next tree of the
    > > driver. Once it has been accepted into your tree, I'll delete the
    > > staging driver. Or, if you want to give your ACK, I can just move the
    > > driver from staging into this directory in my tree, which will properly
    > > preserve the history of the code.
    >
    >
    > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
    > > index d163bc2..da9aed1 100644
    > > --- a/drivers/platform/x86/Kconfig
    > > +++ b/drivers/platform/x86/Kconfig
    > > @@ -654,4 +654,17 @@ config XO1_RFKILL
    > > Support for enabling/disabling the WLAN interface on the OLPC XO-1
    > > laptop.
    > >
    > > +config SAMSUNG_LAPTOP
    > > + tristate "Samsung Laptop driver"
    > > + depends on RFKILL && BACKLIGHT_CLASS_DEVICE && X86
    >
    > This entire Kconfig file already depends on X86, so the "&& X86" above
    > is redundant.

    Ah, yeah, nice catch, that came from when it was stand-alone in the
    staging directory. Can't hurt though :)

    Matthew, want me to respin for this change?

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2011-02-09 23:53    [W:0.020 / U:0.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site