Messages in this thread |  | | From | Linus Torvalds <> | | Date | Wed, 9 Feb 2011 14:00:48 -0800 | | Subject | Re: Linux 2.6.38-rc4 (hysdn: BUG) |
| |
On Wed, Feb 9, 2011 at 1:57 PM, David Miller <davem@davemloft.net> wrote: > > I propose we just kill this stuff off completely. > > I note that there is code in other places of this driver that copy > the read-only revision string into a local string buffer then pass > it into the hysdn_getrev() function, it just doesn't happen in this > one spot. > > Anyways, I think I'll fix this like so:
Ack from me. Removing terminally buggy and pointless code is certainly better than trying to fix it up. No amount of lipstick will make that pig look good.
Linus
|  |