lkml.org 
[lkml]   [2011]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/10] Add yaffs2 file system: Fifth patchset
Date
On Wednesday 09 February 2011 17:52:21 Christoph Hellwig wrote:
> On Wed, Feb 09, 2011 at 04:25:58PM +1300, Charles Manning wrote:
> > Comments/feedback welcome, but I'm hopefully getting pretty close to
> > acceptance :-).
>
> It's not anywhere near ready as long as you insist keeping that silly
> Linux glue code.

Can you be a bit more specific?

Did you actually look or did you just get hives when you saw "glue code"? The
current glue code is very far from what was in the original patch set. In the
first set there were all sorts of abstractions which have been purged and
almost entirely removed.

The current "glue code" really just partitions off the vfs interaction from
the file system internal operations.

This partitioning serves a purpose: it allows the code to be easily integrated
into applications etc (ie outside of the kernel) and also allows the
multi-version code to be supported more cleanly. Multi-version is incredibly
important in the RealWorld (TM).

> Also make sure it passes the xfstests QA suite
> (http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=summary), which
> might need a bit work to be made run depending on how quirky your
> mkfs/fsck tools are.

Thanks. I'll try those.

It does pass fsx and some other tests.

-- Charles






\
 
 \ /
  Last update: 2011-02-09 19:31    [from the cache]
©2003-2011 Jasper Spaans