lkml.org 
[lkml]   [2011]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH V1 1/3] drivers/staging: kztmem: in-kernel tmem code
> From: Konrad Rzeszutek Wilk
> Subject: Re: [PATCH V1 1/3] drivers/staging: kztmem: in-kernel tmem
> code
>
> On Tue, Jan 18, 2011 at 09:19:50AM -0800, Dan Magenheimer wrote:
> > [PATCH V1 1/3] drivers/staging: kztmem: in-kernel tmem code
>
> Hey Dan,
>
> I never finished this review, but sending my fragmented comments
> in case the one you posted has overlap.

Thanks Konrad for the thorough review! I'll fix the nits at the
next version of zcache but will assume (unless you feel otherwise)
that none of these is a showstopper for zcache to be accepted as
a staging driver.

To answer your one question:

> persistent and ephemeral pages can both be in PAM space?

Yes, persistent vs ephemeral is an attribute of the
"struct tmem_pool" and a pointer to the pool is passed
to all PAM callbacks.

Thanks,
Dan


\
 
 \ /
  Last update: 2011-02-09 18:01    [W:0.106 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site