Messages in this thread | | | Subject | Re: [PATCH RESENT#2] [AVR32] don't check platform_get_irq's return value against zero | From | Hans-Christian Egtvedt <> | Date | Wed, 09 Feb 2011 13:51:00 +0100 |
| |
On Wed, 2011-02-09 at 13:44 +0100, Uwe Kleine-König wrote: > On Wed, Feb 09, 2011 at 01:28:52PM +0100, Hans-Christian Egtvedt wrote: > > On Wed, 2011-02-09 at 11:28 +0100, Uwe Kleine-König wrote: > > > platform_get_irq returns -ENXIO on failure, so !int_irq was probably > > > always true. Better use (int)int_irq <= 0. Note that a return value of > > > zero is still handled as error even though this could mean irq0. > > > > > > This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that > > > changed the return value of platform_get_irq from 0 to -ENXIO on error. > > > > > > Acked-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > --- > > > Hello, > > > > > > Hans-Christian Egtvedt asked to push this patch via Linus as there is no avr32 > > > tree. > > > > > > @Andrew: do you take it? > > > > Actually, now I have a tree for AVR32 on git.kernel.org, but I have no > > other updates lined up for 2.6.38. Will you Andrew add it to your > > series, or should I push this one through my git tree? > I don't consider it that critical. So for me getting it in the avr32 > tree now and then getting it merged for .39 would be OK for me.
Okay, then I'll schedule it for the next release.
-- Hans-Christian Egtvedt
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |