Messages in this thread | | | Date | Wed, 9 Feb 2011 12:16:38 +0100 | Subject | Re: [PATCH 4/5] staging: ft1000: Fix coding style in write_blk_fifo() function. | From | Belisko Marek <> |
| |
On Wed, Feb 9, 2011 at 12:08 PM, Dan Carpenter <error27@gmail.com> wrote: > On Wed, Feb 09, 2011 at 11:07:19AM +0100, Belisko Marek wrote: >> Well I test it and it seems very strange and can't figure out why. >> Will remove all byte_length manipulations and device doesn't boot properly >> (finish with error). Add some prinkt to code figure out following: >> >> 1. byte_length = word_length *4 is < 64 we need to send via usb 68 >> bytes (despite >> 4 bytes are behind 64 (without this it can't boot). >> >> 2. also when e.g. word_length is 400 (400*4 = 1600) condition >> 1600%64 == 0 is valid and we send 1604 bytes to usb (also not sure why >> but without this change it also doesn't work). >> > > Huh. Strange. Thanks for testing. Sorry for the noise. No problem ;). Thanks for reviewing and making noise ;). @greg: could you please apply posted patch(thanks): http://driverdev.linuxdriverproject.org/pipermail/devel/2011-February/011942.html > > regards, > dan carpenter > > >
thanks,
marek
-- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite icq: 290551086 web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |