Messages in this thread | | | Date | Tue, 8 Feb 2011 20:03:02 +1000 | From | Greg Ungerer <> | Subject | Re: [patch 07/10] m68knommu: Convert 5272 intc irq_chip to new functions |
| |
Hi Thomas,
On 08/02/11 19:48, Thomas Gleixner wrote: > On Tue, 8 Feb 2011, Greg Ungerer wrote: >>> static void intc_external_irq(unsigned int irq, struct irq_desc *desc) >>> { >>> - desc->chip->ack(irq); >>> + get_irq_desc_chip(i)->irq_ack(desc->irq_data); >> ^^^ ^^^ >> should this be: >> >> get_irq_desc_chip(desc)->irq_ack(&desc->irq_data) > > Yes. > >> I can't runtime test this right at the moment, but otherwise: >> >> Acked-by: Greg Ungerer<gerg@uclinux.org> > > Can you push that stuff linus wards for 39 or want me to do it ? It > has no dependencies whatsoever.
I am happy to push this for 39.
Thanks Greg
------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
| |