lkml.org 
[lkml]   [2011]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [V9fs-developer] [RFC PATCH -V2 01/17] fs/9p: set the cached file_operations struct during inode init
    From
    On Sat, Feb 5, 2011 at 11:46 AM, Aneesh Kumar K.V
    <aneesh.kumar@linux.vnet.ibm.com> wrote:

    >  /**
    >  * v9fs_file_open - open a file (or directory)
    >  * @inode: inode to be opened
    > @@ -89,19 +86,12 @@ int v9fs_file_open(struct inode *inode, struct file *file)
    >        }
    >
    >        file->private_data = fid;
    > +#ifdef CONFIG_9P_FSCACHE
    >        if ((fid->qid.version) && (v9ses->cache)) {
    >                P9_DPRINTK(P9_DEBUG_VFS, "cached");
    > -               /* enable cached file options */
    > -               if(file->f_op == &v9fs_file_operations)
    > -                       file->f_op = &v9fs_cached_file_operations;
    > -               else if (file->f_op == &v9fs_file_operations_dotl)
    > -                       file->f_op = &v9fs_cached_file_operations_dotl;
    > -
    > -#ifdef CONFIG_9P_FSCACHE
    >                v9fs_cache_inode_set_cookie(inode, file);
    > -#endif
    >        }
    > -
    > +#endif
    >        return 0;
    >  }

    Doesn't this conditionalize all cached operations on FSCACHE operation?
    What if we want loose cache policy without FSCACHE?

    -eric
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-02-07 16:05    [W:0.020 / U:179.644 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site