Messages in this thread | | | Date | Mon, 7 Feb 2011 09:30:47 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 3/4] olpc_dcon: move more variables into dcon_priv |
| |
On Sun, Feb 06, 2011 at 03:28:46PM -0800, Andres Salomon wrote: > bool mono:1; > + bool asleep:1; ^^
Not needed.
> - return sprintf(buf, "%d\n", dcon_sleep_val); > + struct dcon_priv *dcon = dev_get_drvdata(dev); > + return sprintf(buf, "%d\n", dcon->asleep ? 1 : 0); ^^^^^^^
Also not needed.
These are fussy things. Feel free to fix them in a later patch series.
regards, dan carpenter
| |