Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] Export linux/syslog.h | Date | Mon, 7 Feb 2011 13:55:55 +0100 |
| |
On Monday 07 February 2011, Paul Bolle wrote: > Userspace programs (like util-linux' dmesg) still use magic numbers for > the klogctl function (glibc's interface to the syslog system call). > Exporting linux/syslog.h makes the more descriptive named constants > available as a single reference for these values. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > Signed-off-by: Kees Cook <kees.cook@canonical.com>
It sounds reasonable to make this a proper ABI in general.
The comment in the header file currently starts with "Syslog internals". If you want to export it, you should probably change that, too. Further, the man page currently documents the raw numbers and should be changed as well with the new constants.
Arnd
| |