[lkml]   [2011]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[Updated][PATCH 1/2] ACPI / Wakeup: Enable button GPEs unconditionally during initialization
    From: Rafael J. Wysocki <>
    Subject: ACPI / Wakeup: Enable button GPEs unconditionally during initialization

    Commit 9630bdd (ACPI: Use GPE reference counting to support shared
    GPEs) introduced a suspend regression where boxes resume immediately
    after being suspended due to the lid or sleep button wakeup status
    not being cleared properly. This happens if the GPEs corresponding
    to those devices are not enabled all the time, which apparently is
    expected by some BIOSes.

    To fix this problem, enable button and lid GPEs unconditionally
    during initialization and keep them enabled all the time, regardless
    of whether or not the ACPI button driver is used.

    Reported-and-tested-by: Ferenc Wágner <>
    Signed-off-by: Rafael J. Wysocki <>


    This time with the correct diffstat.


    drivers/acpi/wakeup.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    Index: linux-2.6/drivers/acpi/wakeup.c
    --- linux-2.6.orig/drivers/acpi/wakeup.c
    +++ linux-2.6/drivers/acpi/wakeup.c
    @@ -86,8 +86,12 @@ int __init acpi_wakeup_device_init(void)
    struct acpi_device *dev = container_of(node,
    struct acpi_device,
    - if (device_can_wakeup(&dev->dev))
    + if (device_can_wakeup(&dev->dev)) {
    + /* Button GPEs are supposed to be always enabled. */
    + acpi_enable_gpe(dev->wakeup.gpe_device,
    + dev->wakeup.gpe_number);
    device_set_wakeup_enable(&dev->dev, true);
    + }
    return 0;
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at
     \ /
      Last update: 2011-02-06 15:27    [W:0.024 / U:60.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site