lkml.org 
[lkml]   [2011]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/09] ARM: s3c2440: gta02: Request usb pullup pin before using it
    Date
    Request the gpio pin used to control the usb pullup before using it to avoid a
    runtime warning about an auto-requested gpio.

    Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
    ---
    arch/arm/mach-s3c2440/mach-gta02.c | 17 +++++++++++++++--
    1 files changed, 15 insertions(+), 2 deletions(-)

    diff --git a/arch/arm/mach-s3c2440/mach-gta02.c b/arch/arm/mach-s3c2440/mach-gta02.c
    index 1396639..94456fa 100644
    --- a/arch/arm/mach-s3c2440/mach-gta02.c
    +++ b/arch/arm/mach-s3c2440/mach-gta02.c
    @@ -451,11 +451,11 @@ static void gta02_udc_command(enum s3c2410_udc_cmd_e cmd)
    switch (cmd) {
    case S3C2410_UDC_P_ENABLE:
    pr_debug("%s S3C2410_UDC_P_ENABLE\n", __func__);
    - gpio_direction_output(GTA02_GPIO_USB_PULLUP, 1);
    + gpio_set_value(GTA02_GPIO_USB_PULLUP, 1);
    break;
    case S3C2410_UDC_P_DISABLE:
    pr_debug("%s S3C2410_UDC_P_DISABLE\n", __func__);
    - gpio_direction_output(GTA02_GPIO_USB_PULLUP, 0);
    + gpio_set_value(GTA02_GPIO_USB_PULLUP, 0);
    break;
    case S3C2410_UDC_P_RESET:
    pr_debug("%s S3C2410_UDC_P_RESET\n", __func__);
    @@ -572,11 +572,24 @@ static void gta02_poweroff(void)
    pcf50633_reg_set_bit_mask(gta02_pcf, PCF50633_REG_OOCSHDWN, 1, 1);
    }

    +static void gta02_request_gpios(void)
    +{
    + int ret;
    + ret = gpio_request_one(GTA02_GPIO_USB_PULLUP, GPIOF_OUT_INIT_LOW,
    + "USB pullup");
    + if (ret) {
    + printk(KERN_ERR "Failed to request USB pullup gpio pin: %d\n",
    + ret);
    + }
    +}
    +
    static void __init gta02_machine_init(void)
    {
    /* Set the panic callback to turn AUX LED on or off. */
    panic_blink = gta02_panic_blink;

    + gta02_request_gpios();
    +
    s3c_pm_init();

    #ifdef CONFIG_CHARGER_PCF50633
    --
    1.7.2.3


    \
     
     \ /
      Last update: 2011-02-07 02:53    [W:0.021 / U:180.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site