lkml.org 
[lkml]   [2011]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/5] net: sysctl: share ipv4/ipv6 sysctl tables
    On Fri, Feb 04, 2011 at 05:59:24PM +0200, Lucian Adrian Grijincu wrote:
    > On Fri, Feb 4, 2011 at 12:49 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
    > >> Finally share the leaf sysctl tables for ipv4/ipv6:
    > >>
    > >>  [PATCH 4/5] ipv4: share sysctl net/ipv4/conf/DEVNAME/ tables
    > >>  [PATCH 5/5] ipv6: share sysctl net/ipv6/conf/DEVNAME/ tables
    > >
    > > Meh.
    > >
    > > First you remove ->parent, then heroically pass "struct file *"
    > > to sysctl handlers which duplicates all information already passed
    > > and brings dcache into picture.
    > >
    > > Binary sysctl rewrite confused you into thinking that d_name.name
    > > is the way, but it isn't.
    > > For binary sysctl(2) you wouldn't get d_name.name.
    >
    >
    > Are you really sure?
    >
    > I ran this code on a machine with and without these patches. It seems
    > to work fine.
    >
    > It reads the value from /proc/sys/net/ipv4/conf/default/tag and writes 42 back.
    >
    > I'm not sure what I have to do to pass the name of a device (e.g.
    > "eth0") instead of "default" but at least "default" and "all" work and
    > have valid dentries.

    You do ->parent->procname.

    But, but you removed parent.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-02-05 15:29    [W:0.021 / U:157.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site