[lkml]   [2011]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v6] spi: New driver for Altera SPI
    On 02/04/2011 01:34 AM, Grant Likely wrote:
    > Hi Thomas, comments below, but looking pretty close.

    Thanks a lot.

    >> +config SPI_ALTERA
    >> + tristate "Altera SPI Controller"
    >> + select SPI_BITBANG
    > Will this compile on all architectures? Will it break allyesconfig
    > on anything other than nios?

    Yes, it compile on other architectures. I will add 'default n' though.

    There are soft-core arm, mips and coldfire running on altera fpga.
    Others might use fpga as peripheral extender, too. So we shouldn't limit
    it to nios2.

    >> +static int __init altera_spi_init(void)
    >> +{
    >> + return platform_driver_probe(&altera_spidrv, altera_spi_probe);
    > platform_driver_register() please, and put the altera_spi_probe()
    > routine into the driver structure.

    I will change it to register as you suggested.

    - Thomas

     \ /
      Last update: 2011-02-05 14:11    [W:0.019 / U:3.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site