Messages in this thread | | | Date | Sun, 06 Feb 2011 02:29:24 +0300 | From | Sergei Shtylyov <> | Subject | Re: [USB]Add Samsung SGH-I500/Android modem ID switch to visor driver |
| |
Hello.
On 06.02.2011 0:41, Maciej Szmigiero wrote:
> New version of patch which autodetects devices with ACM class. > Tested on Galaxy Spica.
> Signed-off-by: Maciej Szmigiero <mhej@o2.pl>
> diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c > index 15a5d89..e1c4527 100644 > --- a/drivers/usb/serial/visor.c > +++ b/drivers/usb/serial/visor.c [...] > @@ -479,6 +480,15 @@ static int visor_probe(struct usb_serial *serial, > > dbg("%s", __func__); > > + /* some Samsung Android phones in modem mode have the same ID */ > + /* as SPH-I500, but they are ACM devices, so dont bind to them */
The preferred style for the multi-line comments is this:
/* * bla * bla */
> + if ((id->idVendor == SAMSUNG_VENDOR_ID)&& > + (id->idProduct == SAMSUNG_SPH_I500_ID)&& > + (serial->dev->descriptor.bDeviceClass == USB_CLASS_COMM)&& > + (serial->dev->descriptor.bDeviceSubClass == > + USB_CDC_SUBCLASS_ACM))
Parens around == not necessary...
WBR, Sergei
| |