lkml.org 
[lkml]   [2011]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -perf/perf/core 1/4] tracing/kprobes: Cleanup strict_strtol() using code
    Date
    Since strict_strtol() accepts minus digits started with '-',
    it doesn' need to invert after converting.

    Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: linux-kernel@vger.kernel.org
    ---

    kernel/trace/trace_kprobe.c | 5 ++---
    1 files changed, 2 insertions(+), 3 deletions(-)

    diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
    index 2dec9bc..2088893 100644
    --- a/kernel/trace/trace_kprobe.c
    +++ b/kernel/trace/trace_kprobe.c
    @@ -767,16 +767,15 @@ static int __parse_probe_arg(char *arg, const struct fetch_type *t,
    }
    break;
    case '+': /* deref memory */
    + arg++; /* Skip '+', because strict_strtol() rejects it. */
    case '-':
    tmp = strchr(arg, '(');
    if (!tmp)
    break;
    *tmp = '\0';
    - ret = strict_strtol(arg + 1, 0, &offset);
    + ret = strict_strtol(arg, 0, &offset);
    if (ret)
    break;
    - if (arg[0] == '-')
    - offset = -offset;
    arg = tmp + 1;
    tmp = strrchr(arg, ')');
    if (tmp) {


    \
     
     \ /
      Last update: 2011-02-04 14:01    [W:0.022 / U:29.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site