lkml.org 
[lkml]   [2011]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 20/20] fs: ubifs: world-writable debugfs dump_* files
    Date
    Don't allow everybody to dump sensitive information about filesystems.

    Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
    ---
    Compile tested only.

    fs/ubifs/debug.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
    index 0bee4db..bcb1acb 100644
    --- a/fs/ubifs/debug.c
    +++ b/fs/ubifs/debug.c
    @@ -2813,19 +2813,19 @@ int dbg_debugfs_init_fs(struct ubifs_info *c)
    }

    fname = "dump_lprops";
    - dent = debugfs_create_file(fname, S_IWUGO, d->dfs_dir, c, &dfs_fops);
    + dent = debugfs_create_file(fname, S_IWUSR, d->dfs_dir, c, &dfs_fops);
    if (IS_ERR(dent))
    goto out_remove;
    d->dfs_dump_lprops = dent;

    fname = "dump_budg";
    - dent = debugfs_create_file(fname, S_IWUGO, d->dfs_dir, c, &dfs_fops);
    + dent = debugfs_create_file(fname, S_IWUSR, d->dfs_dir, c, &dfs_fops);
    if (IS_ERR(dent))
    goto out_remove;
    d->dfs_dump_budg = dent;

    fname = "dump_tnc";
    - dent = debugfs_create_file(fname, S_IWUGO, d->dfs_dir, c, &dfs_fops);
    + dent = debugfs_create_file(fname, S_IWUSR, d->dfs_dir, c, &dfs_fops);
    if (IS_ERR(dent))
    goto out_remove;
    d->dfs_dump_tnc = dent;
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-02-04 13:27    [W:0.032 / U:0.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site