lkml.org 
[lkml]   [2011]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 15/20] platform: x86: asus_acpi: world-writable procfs files
    Date
    Don't allow everybody to change ACPI settings.  The comment says that it
    is done deliberatelly, however, the comment before disp_proc_write()
    says that at least one of these setting is experimental.

    Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
    ---
    Compile tested only.

    drivers/platform/x86/asus_acpi.c | 8 +-------
    1 files changed, 1 insertions(+), 7 deletions(-)

    diff --git a/drivers/platform/x86/asus_acpi.c b/drivers/platform/x86/asus_acpi.c
    index 4633fd8..fe49593 100644
    --- a/drivers/platform/x86/asus_acpi.c
    +++ b/drivers/platform/x86/asus_acpi.c
    @@ -1081,14 +1081,8 @@ static int asus_hotk_add_fs(struct acpi_device *device)
    struct proc_dir_entry *proc;
    mode_t mode;

    - /*
    - * If parameter uid or gid is not changed, keep the default setting for
    - * our proc entries (-rw-rw-rw-) else, it means we care about security,
    - * and then set to -rw-rw----
    - */
    -
    if ((asus_uid == 0) && (asus_gid == 0)) {
    - mode = S_IFREG | S_IRUGO | S_IWUGO;
    + mode = S_IFREG | S_IRUGO | S_IWUSR | S_IWGRP;
    } else {
    mode = S_IFREG | S_IRUSR | S_IRGRP | S_IWUSR | S_IWGRP;
    printk(KERN_WARNING " asus_uid and asus_gid parameters are "
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-02-04 13:27    [W:0.024 / U:1.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site