lkml.org 
[lkml]   [2011]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/20] mfd: ab8500: world-writable debugfs register-* files
    Date
    Don't allow everybody to interact with hardware registers.

    Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
    ---
    Compile tested only.

    drivers/mfd/ab8500-debugfs.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
    index 3c1541a..64748e4 100644
    --- a/drivers/mfd/ab8500-debugfs.c
    +++ b/drivers/mfd/ab8500-debugfs.c
    @@ -585,18 +585,18 @@ static int __devinit ab8500_debug_probe(struct platform_device *plf)
    goto exit_destroy_dir;

    ab8500_bank_file = debugfs_create_file("register-bank",
    - (S_IRUGO | S_IWUGO), ab8500_dir, &plf->dev, &ab8500_bank_fops);
    + (S_IRUGO | S_IWUSR), ab8500_dir, &plf->dev, &ab8500_bank_fops);
    if (!ab8500_bank_file)
    goto exit_destroy_reg;

    ab8500_address_file = debugfs_create_file("register-address",
    - (S_IRUGO | S_IWUGO), ab8500_dir, &plf->dev,
    + (S_IRUGO | S_IWUSR), ab8500_dir, &plf->dev,
    &ab8500_address_fops);
    if (!ab8500_address_file)
    goto exit_destroy_bank;

    ab8500_val_file = debugfs_create_file("register-value",
    - (S_IRUGO | S_IWUGO), ab8500_dir, &plf->dev, &ab8500_val_fops);
    + (S_IRUGO | S_IWUSR), ab8500_dir, &plf->dev, &ab8500_val_fops);
    if (!ab8500_val_file)
    goto exit_destroy_address;

    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-02-04 13:27    [W:0.021 / U:0.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site