Messages in this thread | | | Date | Fri, 04 Feb 2011 11:06:17 +0100 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH TIP v2 03/14] x86/dtb: Add a device tree for CE4100 |
| |
Grant Likely wrote: > You can go ahead and keep the revision history above the s-o-b and --- > lines. It turns out that having the revision history in the commit > text is actually useful when trying to figure out what version of a > patch actually got applied. Okay.
>> diff --git a/arch/x86/platform/ce4100/falconfalls.dts b/arch/x86/platform/ce4100/falconfalls.dts >> new file mode 100644 >> index 0000000..e888657 >> --- /dev/null >> +++ b/arch/x86/platform/ce4100/falconfalls.dts >> @@ -0,0 +1,424 @@
>> + soc@0 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "intel,ce4100-cp"; > > You'll need to add blurbs to Documentation/devicetree/bindings > (Documentation/powerpc/dts-bindings in Linus' tree; renamed in > linux-next) for each of these new compatible bindings to document the > part that they describe and any special properties that go with each > compatible value (if any). You can send it as a followup patch.
Good point, will do.
>> + gpio@b,1 { >> + compatible = "pci8086,2e67.2", >> + "pci8086,2e67", >> + "pciclassff0000", >> + "pciclassff00"; >> + >> + reg = <0x15900 0x0 0x0 0x0 0x0>; >> + interrupts = <15 1>; >> + }; > > You'll probably want to make use of the gpio-controller binding for > the gpio nodes so that other nodes can reference it. Not a > showstopper for this patch though.
Right. I'll make it follow-up once I get to the gpio functionality.
> Otherwise looks good to me. thanks.
> g.
Sebastian
| |