lkml.org 
[lkml]   [2011]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/20] mach-omap2: mux: world-writable debugfs files
* Vasiliy Kulikov <segoon@openwall.com> [110204 04:21]:
> Do not create mux debugfs files as world-writable.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Cannot compile the driver, so it is not tested at all.

Thanks, will queue this as a fix for the -rc cycle.

Tony

> arch/arm/mach-omap2/mux.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
> index 98148b6..6c84659 100644
> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -605,7 +605,7 @@ static void __init omap_mux_dbg_create_entry(
> list_for_each_entry(e, &partition->muxmodes, node) {
> struct omap_mux *m = &e->mux;
>
> - (void)debugfs_create_file(m->muxnames[0], S_IWUGO, mux_dbg_dir,
> + (void)debugfs_create_file(m->muxnames[0], S_IWUSR, mux_dbg_dir,
> m, &omap_mux_dbg_signal_fops);
> }
> }
> --
> 1.7.0.4
>


\
 
 \ /
  Last update: 2011-02-04 21:13    [W:0.032 / U:2.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site