lkml.org 
[lkml]   [2011]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH 5/6] teach smaps_pte_range() about THP pmds
From
Date
On Thu, 2011-02-03 at 13:22 -0800, David Rientjes wrote:
> > @@ -385,6 +386,17 @@ static int smaps_pte_range(pmd_t *pmd, u
> > pte_t *pte;
> > spinlock_t *ptl;
> >
> > + if (pmd_trans_huge(*pmd)) {
> > + if (pmd_trans_splitting(*pmd)) {
> > + spin_unlock(&walk->mm->page_table_lock);
> > + wait_split_huge_page(vma->anon_vma, pmd);
> > + spin_lock(&walk->mm->page_table_lock);
> > + goto normal_ptes;
> > + }
> > + smaps_pte_entry(*(pte_t *)pmd, addr, HPAGE_SIZE, walk);
> > + return 0;
> > + }
> > +normal_ptes:
>
> Small nitpick: the label isn't necessary, just use an else-clause on your
> nested conditional.

Works for me.

> > split_huge_page_pmd(walk->mm, pmd);
> >
> > pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl);
> > diff -puN mm/vmscan.c~teach-smaps_pte_range-about-thp-pmds mm/vmscan.c
> > diff -puN include/trace/events/vmscan.h~teach-smaps_pte_range-about-thp-pmds include/trace/events/vmscan.h
> > diff -puN mm/pagewalk.c~teach-smaps_pte_range-about-thp-pmds mm/pagewalk.c
> > diff -puN mm/huge_memory.c~teach-smaps_pte_range-about-thp-pmds mm/huge_memory.c
> > diff -puN mm/memory.c~teach-smaps_pte_range-about-thp-pmds mm/memory.c
> > diff -puN include/linux/huge_mm.h~teach-smaps_pte_range-about-thp-pmds include/linux/huge_mm.h
> > diff -puN mm/internal.h~teach-smaps_pte_range-about-thp-pmds mm/internal.h
> > _
>
> What are all these?

Junk. I'll pull them out.

-- Dave



\
 
 \ /
  Last update: 2011-02-03 22:37    [W:0.100 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site