[lkml]   [2011]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 12/19] twl4030: mfd_cell is now implicitly available to drivers
On Wed, Feb 02, 2011 at 08:15:22PM -0800, Andres Salomon wrote:
> static int __devinit twl4030_vibra_probe(struct platform_device *pdev)
> {
> - struct twl4030_codec_vibra_data *pdata = pdev->dev.platform_data;
> + struct twl4030_codec_vibra_data *pdata = platform_get_drvdata(pdev);

No, device's drvdata belongs to _this_ driver, and it is supposed to
manage it and use as it sees fit.

Note platform_set_drvdata(pdev, info) later in this function along with
platform_set_drvdata(pdev, NULL) in twl4030_vibra_remove(), which means
that with your change you will be able to bind the device only once.


 \ /
  Last update: 2011-02-03 07:07    [W:0.166 / U:28.040 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site