lkml.org 
[lkml]   [2011]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [tip:sched/core] sched: Add yield_to(task, preempt) functionality
    From
    Date
    On Sat, 2011-02-26 at 00:44 -0500, Rik van Riel wrote:
    > On 02/25/2011 07:43 PM, Venkatesh Pallipadi wrote:

    > > The below comment says about rescheduling p's CPU. But the rq variable
    > > we have here is the curr_rq and not p_rq. So, should this be done in
    > > yield_to() with p_rq. I did try to see the discussion on other
    > > versions of this patch. v3 and before had -
    > > "resched_task(task_of(p_cfs_rq->curr));" which seems to be correct...
    >
    > You are correct. We are calling resched_task on the wrong task,
    > we should call it on p's runqueue's current task...

    Are you going to send a fix?

    > >> +
    > >> + /* Make p's CPU reschedule; pick_next_entity takes care of fairness. */
    > >> + if (preempt)
    > >> + resched_task(rq->curr);




    \
     
     \ /
      Last update: 2011-02-28 10:29    [W:0.026 / U:152.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site