lkml.org 
[lkml]   [2011]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[06/68] Fix pktcdvd ioctl dev_minor range check
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Dan Rosenberg <drosenberg@vsecurity.com>

    commit 252a52aa4fa22a668f019e55b3aac3ff71ec1c29 upstream.

    The PKT_CTRL_CMD_STATUS device ioctl retrieves a pointer to a
    pktcdvd_device from the global pkt_devs array. The index into this
    array is provided directly by the user and is a signed integer, so the
    comparison to ensure that it falls within the bounds of this array will
    fail when provided with a negative index.

    This can be used to read arbitrary kernel memory or cause a crash due to
    an invalid pointer dereference. This can be exploited by users with
    permission to open /dev/pktcdvd/control (on many distributions, this is
    readable by group "cdrom").

    Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
    [ Rather than add a cast, just make the function take the right type -Linus ]
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/block/pktcdvd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/block/pktcdvd.c
    +++ b/drivers/block/pktcdvd.c
    @@ -2408,7 +2408,7 @@ static void pkt_release_dev(struct pktcd
    pkt_shrink_pktlist(pd);
    }

    -static struct pktcdvd_device *pkt_find_dev_from_minor(int dev_minor)
    +static struct pktcdvd_device *pkt_find_dev_from_minor(unsigned int dev_minor)
    {
    if (dev_minor >= MAX_WRITERS)
    return NULL;



    \
     
     \ /
      Last update: 2011-02-28 17:41    [W:0.020 / U:29.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site