lkml.org 
[lkml]   [2011]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRE: [PATCH 09/09] ARM: s3c2440: gta02: Add touchscreen support
    Lars-Peter Clausen wrote:
    >
    > On 02/28/2011 07:04 AM, Kukjin Kim wrote:
    > > Lars-Peter Clausen wrote:
    > >>

    (snip)

    > >> /* Buttons */
    > >> static struct gpio_keys_button gta02_buttons[] = {
    > >> {
    > >> @@ -533,6 +542,8 @@ static struct platform_device *gta02_devices[]
    > > __initdata
    > >> = {
    > >> &samsung_asoc_dma,
    > >> &s3c_device_i2c0,
    > >> &gta02_buttons_device,
    > >> + &s3c_device_adc,
    > >
    > > No need to build plat-samsung/dev-adc.c for this?
    > > If you want to add '&s3c_deivce_adc', should add 'select
    SAMSUNG_DEV_ADC'
    > > into "config MACH_NEO1973_GTA02".
    >
    > There appear to be two different definitions for s3c_deivce_adc one is in
    > plat-samsung/dev-adc.c the other is in plat-s3c24xx/devs.c. So if I select
    > SAMSUNG_DEV_ADC I'll actually get compile errors.
    > The definition in plat-s3c24xx/devs.c should probably be dropped, but
    thats
    > something for a different patch.
    >
    Oops, you're right...ok, please keep your current code.
    If required, we can do it later :)

    (snip)

    Thanks.

    Best regards,
    Kgene.
    --
    Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
    SW Solution Development Team, Samsung Electronics Co., Ltd.



    \
     
     \ /
      Last update: 2011-02-28 11:59    [W:0.026 / U:59.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site