lkml.org 
[lkml]   [2011]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/09] ARM: s3c2440: gta02: Add touchscreen support
On 02/28/2011 07:04 AM, Kukjin Kim wrote:
> Lars-Peter Clausen wrote:
>>
>> This patch registers the s3c touchscreen and adc devices to add
> touchscreen
>> support for the gta02.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> ---
>> arch/arm/mach-s3c2440/mach-gta02.c | 12 ++++++++++++
>> 1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-s3c2440/mach-gta02.c
> b/arch/arm/mach-s3c2440/mach-
>> gta02.c
>> index 94456fa..2300ec5 100644
>> --- a/arch/arm/mach-s3c2440/mach-gta02.c
>> +++ b/arch/arm/mach-s3c2440/mach-gta02.c
>> @@ -79,6 +79,8 @@
>> #include <mach/regs-mem.h>
>> #include <mach/hardware.h>
>>
>> +#include <plat/ts.h>
>> +
>
> Please group same/similar inclusion together like following.
> <linux/...> <asm/...> then <mach/...> or <plat/...>
>
> In other words, please add your <plat/ts.h> inclusion after other <plat/...>

Ok.
>
>> #include <mach/gta02.h>
>>
>> #include <plat/regs-serial.h>
>> @@ -480,6 +482,13 @@ static struct s3c2410_hcd_info gta02_usb_info
> __initdata
>> = {
>> },
>> };
>>
>> +/* Touchscreen */
>> +static struct s3c2410_ts_mach_info gta02_ts_info = {
>> + .delay = 10000,
>> + .presc = 0xff, /* slow as we can go */
>> + .oversampling_shift = 2,
>> +};
>
> How about to use tab between member and = like following?
>
> static struct s3c2410_ts_mach_info gta02_ts_info = {
> .delay = 10000,
> .presc = 0xff, /* slow as we can go */
> .oversampling_shift = 2,
> };

Ok.

>
>> +
>> /* Buttons */
>> static struct gpio_keys_button gta02_buttons[] = {
>> {
>> @@ -533,6 +542,8 @@ static struct platform_device *gta02_devices[]
> __initdata
>> = {
>> &samsung_asoc_dma,
>> &s3c_device_i2c0,
>> &gta02_buttons_device,
>> + &s3c_device_adc,
>
> No need to build plat-samsung/dev-adc.c for this?
> If you want to add '&s3c_deivce_adc', should add 'select SAMSUNG_DEV_ADC'
> into "config MACH_NEO1973_GTA02".

There appear to be two different definitions for s3c_deivce_adc one is in
plat-samsung/dev-adc.c the other is in plat-s3c24xx/devs.c. So if I select
SAMSUNG_DEV_ADC I'll actually get compile errors.
The definition in plat-s3c24xx/devs.c should probably be dropped, but thats
something for a different patch.


>
>> + &s3c_device_ts,
>
> 'select SAMSUNG_DEV_TS'

Same here.

>
>> };
>>
>> /* These guys DO need to be children of PMU. */
>> @@ -597,6 +608,7 @@ static void __init gta02_machine_init(void)
>> #endif
>>
>> s3c24xx_udc_set_platdata(&gta02_udc_cfg);
>> + s3c24xx_ts_set_platdata(&gta02_ts_info);
>
> Same as above. 'select SAMSUNG_DEV_TS' should be added for
> plat-samsung/dev-ts.c.

And here.

>
>> s3c_ohci_set_platdata(&gta02_usb_info);
>> s3c_nand_set_platdata(&gta02_nand_info);
>> s3c_i2c0_set_platdata(NULL);
>> --
>> 1.7.2.3
>
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>



\
 
 \ /
  Last update: 2011-02-28 11:45    [W:0.067 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site