Messages in this thread Patch in this message | | | Date | Sat, 26 Feb 2011 16:22:27 GMT | From | tip-bot for Thomas Gleixner <> | Subject | [tip:irq/core] genirq: Allow shared oneshot interrupts |
| |
Commit-ID: 9d591edd02a245305b1b9379e4c5571bad4d2774 Gitweb: http://git.kernel.org/tip/9d591edd02a245305b1b9379e4c5571bad4d2774 Author: Thomas Gleixner <tglx@linutronix.de> AuthorDate: Wed, 23 Feb 2011 23:52:16 +0000 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Fri, 25 Feb 2011 20:24:21 +0100
genirq: Allow shared oneshot interrupts
Support ONESHOT on shared interrupts, if all drivers agree on it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Peter Zijlstra <peterz@infradead.org> LKML-Reference: <20110223234956.483640430@linutronix.de> --- kernel/irq/manage.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 2301de1..58c8613 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -824,10 +824,6 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) rand_initialize_irq(irq); } - /* Oneshot interrupts are not allowed with shared */ - if ((new->flags & IRQF_ONESHOT) && (new->flags & IRQF_SHARED)) - return -EINVAL; - /* * Check whether the interrupt nests into another interrupt * thread. @@ -881,10 +877,12 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) * Can't share interrupts unless both agree to and are * the same type (level, edge, polarity). So both flag * fields must have IRQF_SHARED set and the bits which - * set the trigger type must match. + * set the trigger type must match. Also all must + * agree on ONESHOT. */ if (!((old->flags & new->flags) & IRQF_SHARED) || - ((old->flags ^ new->flags) & IRQF_TRIGGER_MASK)) { + ((old->flags ^ new->flags) & IRQF_TRIGGER_MASK) || + ((old->flags ^ new->flags) & IRQF_ONESHOT)) { old_name = old->name; goto mismatch; }
| |