lkml.org 
[lkml]   [2011]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [024/115] USB: prevent buggy hubs from crashing the USB stack
Hi,

On Wed, Feb 23, 2011 at 10:26:20AM -0500, Alan Stern wrote:
> In both cases, it appears that the problem is caused by the fact that
> the musb host-controller driver doesn't set the hcd->has_tt flag.
>
> Felipe, you should know where it belongs. It should be easy enough to
> add.

Sure Alan, it's attached to this mail. Compile tested only though.
Michael, would you care to give your tested-by ?

--
balbi
From 65315c60a17f83e69d01888babe4445097c8ead0 Mon Sep 17 00:00:00 2001
From: Felipe Balbi <balbi@ti.com>
Date: Thu, 24 Feb 2011 10:36:53 +0200
Subject: [PATCH] usb: musb: core: set has_tt flag
Organization: Texas Instruments\n

MUSB is a non-standard host implementation which
can handle all speeds with the same core. We need
to set has_tt flag after commit
d199c96d41d80a567493e12b8e96ea056a1350c1 (USB: prevent
buggy hubs from crashing the USB stack) in order for
MUSB HCD to continue working.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/usb/musb/musb_core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 54a8bd1..c292d5c 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1864,6 +1864,7 @@ allocate_instance(struct device *dev,
INIT_LIST_HEAD(&musb->out_bulk);

hcd->uses_new_polling = 1;
+ hcd->has_tt = 1;

musb->vbuserr_retry = VBUSERR_RETRY_COUNT;
musb->a_wait_bcon = OTG_TIME_A_WAIT_BCON;
--
1.7.4.rc2
\
 
 \ /
  Last update: 2011-02-24 09:59    [W:0.142 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site