lkml.org 
[lkml]   [2011]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6] i2c-gpio: add devicetree support
    On Thu, Feb 24, 2011 at 12:00:13PM +0800, Thomas Chou wrote:
    > From: Albert Herranz <albert_herranz@yahoo.es>
    >
    > This patch adds devicetree support to i2c-gpio driver. The allocation
    > of local data is integrated to a private structure, and use devm_*
    > helper for easy cleanup.
    >
    > It is base on an earlier patch for gc-linux from
    > Albert Herranz <albert_herranz@yahoo.es>.
    >
    > Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
    > CC: Albert Herranz <albert_herranz@yahoo.es>
    > Acked-by: Haavard Skinnemoen <hskinnemoen@gmail.com>
    > Acked-by: Grant Likely <grant.likely@secretlab.ca>
    > ---
    > diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt
    > new file mode 100644
    > index 0000000..38ef4f2
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt
    > @@ -0,0 +1,40 @@
    > +GPIO-based I2C
    > +
    > +Required properties:
    > +- compatible : should be "i2c-gpio".
    > +- gpios : should specify GPIOs used for SDA and SCL lines, in that order.
    > +Optional properties:
    > +- sda-is-open-drain : present if SDA gpio is open-drain.
    > +- scl-is-open-drain : present if SCL gpio is open-drain.
    > +- scl-is-output-only : present if the output driver for SCL cannot be
    > + turned off. this will prevent clock stretching from working.
    > +- speed-hz : SCL frequency.

    Hi Thomas,

    One nitpick; I just looked, and other i2c controllers are already
    using 'clock-frequency' instead of 'speed-hz' for the speed of the
    bus. I'd like to see this patch use the same terminology.

    Otherwise this looks good to me.

    Thanks,
    g.


    \
     
     \ /
      Last update: 2011-02-24 17:25    [W:0.023 / U:1.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site