Messages in this thread | | | Date | Thu, 24 Feb 2011 15:18:09 +0000 | From | Al Viro <> | Subject | Re: [PATCH 0/3] Fixes for vfs-scale and vfs-automount |
| |
On Thu, Feb 24, 2011 at 02:59:47PM +0000, Al Viro wrote:
> Well... In principle, you could mark all mountpoints in a tree as managed, > have an "expiry search in progress" flag to stop everything in there while > the expiry happens, then wait out all RCU walks in progress, then go ahead > with your expiry checks. Would that work for you?
There's at least one leak I can see in expiry.c, BTW - autofs4_expire_direct() leaks root dentry if you hit /* No point expiring a pending mount */ if (ino->flags & AUTOFS_INF_PENDING) { spin_unlock(&sbi->fs_lock); return NULL; } in there. Try to stick dput(root) before that return and see if that's what it is...
| |