lkml.org 
[lkml]   [2011]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order
On Wed, Feb 23, 2011 at 10:55:12PM +0000, Haiyang Zhang wrote:
> > From: Greg KH [mailto:greg@kroah.com]
> > The layering is almost ok, there is still one more layer here than is
> > needed, and it should be removed (I already removed lots of layers that
> > were not needed, just didn't get to this one.) But the naming also
> > needs to be fixed up as it is wrong from a "driver model" standpoint
> > with the rest of the kernel.
>
> So, how about rename the "struct driver_context" to "struct gen_drv_ctx"
> in this patch? We can deal with the layering in next round of patches.

No, it's not a "driver context" at all. It is a "hyperv driver", so
name it as such.

A "context" is a void pointer or something that the driver uses
privately. And you already have a pointer to the context in the base
structure so you don't need your own.

You should work on removing the layering now, that will clean this all
up.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-02-24 00:09    [W:0.038 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site